Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect component reference in angular-cli example #13162

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix incorrect component reference in angular-cli example #13162

merged 1 commit into from
Nov 18, 2020

Conversation

S1ngS1ng
Copy link
Contributor

@S1ngS1ng S1ngS1ng commented Nov 18, 2020 •
edited
Loading

What I did

Fixed a typo

How to test

  • Is this testable with Jest or Chromatic screenshots? Not sure
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

Screenshot

The online version

image

Local with fix

image

@S1ngS1ng
fix incorrect component reference
30c5e98 
the correct name should be "DocButtonComponent"
@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Nov 18, 2020
shilman
shilman approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!

@shilman shilman merged commit c8a819d into storybookjs:next Nov 18, 2020
@shilman shilman added documentation and removed cleanup Minor cleanup style change that won't show up in release changelog labels Nov 18, 2020
@lili2311 lili2311 mentioned this pull request Sep 20, 2023
Open
@lili2311 lili2311 mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S1ngS1ng @shilman